Issue 114480043: code review 114480043: go-tour: remove brace matching addon and unused trailin...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 114480043: code review 114480043: go-tour: remove brace matching addon and unused trailin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by francesc

Modified:
9 years, 9 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

go-tour: remove brace matching addon and unused trailing space addon.

Patch Set 1 #

Patch Set 2 : diff -r 389e3053128b https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 389e3053128b https://code.google.com/p/go-tour #

Patch Set 4 : diff -r 389e3053128b https://code.google.com/p/go-tour #

Patch Set 5 : diff -r 389e3053128b https://code.google.com/p/go-tour #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -102 lines)			Patch
M	gotour/tour.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
R	static/lib/codemirror/addon/edit/matchbrackets.js	View	1 chunk	+0 lines, -86 lines	0 comments	Download
R	static/lib/codemirror/addon/edit/trailingspace.js	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 9 months ago (2014-07-28 15:36:26 UTC) #1

adg

LGTM On Tuesday, 29 July 2014, <campoy@golang.org> wrote: > Reviewers: adg, > > Message: > ...

9 years, 9 months ago (2014-07-28 22:46:05 UTC) #2

francesc

9 years, 9 months ago (2014-07-28 23:51:13 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=be09df761bb0
***

go-tour: remove brace matching addon and unused trailing space addon.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/114480043

Expand All Messages | Collapse All Messages