Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 11408043: code review 11408043: go.tools/cmd/godoc: copy godoc from core reposistory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by adg
Modified:
11 years, 9 months ago
Reviewers:
bradfitz
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

go.tools/cmd/godoc: copy godoc from core reposistory The plan for godoc: - Copy godoc source from the core repo to go.tools (this CL). - Break godoc into several packages inside go.tools, leaving a package main that merely sets up a local file system, interprets the command line, and otherwise delegates the heavy-lifting to the new packages. - Remove godoc from the core repo. - Update cmd/go to install this godoc binary in $GOROOT/bin. - Update misc/dist to include godoc when building binary distributions.

Patch Set 1 #

Patch Set 2 : diff -r daac7d9c4ceb https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6575 lines, -0 lines) Patch
A cmd/godoc/README.godoc-app View 1 chunk +61 lines, -0 lines 0 comments Download
A cmd/godoc/appinit.go View 1 chunk +69 lines, -0 lines 0 comments Download
A cmd/godoc/codewalk.go View 1 chunk +494 lines, -0 lines 0 comments Download
A cmd/godoc/dirtrees.go View 1 chunk +320 lines, -0 lines 0 comments Download
A cmd/godoc/doc.go View 1 chunk +135 lines, -0 lines 0 comments Download
A cmd/godoc/filesystem.go View 1 chunk +562 lines, -0 lines 0 comments Download
A cmd/godoc/format.go View 1 chunk +372 lines, -0 lines 0 comments Download
A cmd/godoc/godoc.go View 1 chunk +1586 lines, -0 lines 0 comments Download
A cmd/godoc/index.go View 1 chunk +1079 lines, -0 lines 0 comments Download
A cmd/godoc/linkify.go View 1 chunk +234 lines, -0 lines 0 comments Download
A cmd/godoc/main.go View 1 chunk +470 lines, -0 lines 0 comments Download
A cmd/godoc/parser.go View 1 chunk +37 lines, -0 lines 0 comments Download
A cmd/godoc/play.go View 1 chunk +52 lines, -0 lines 0 comments Download
A cmd/godoc/play-appengine.go View 1 chunk +35 lines, -0 lines 0 comments Download
A cmd/godoc/play-local.go View 1 chunk +41 lines, -0 lines 0 comments Download
A cmd/godoc/setup-godoc-app.bash View 1 chunk +140 lines, -0 lines 0 comments Download
A cmd/godoc/snippet.go View 1 chunk +112 lines, -0 lines 0 comments Download
A cmd/godoc/spec.go View 1 chunk +179 lines, -0 lines 0 comments Download
A cmd/godoc/template.go View 1 chunk +182 lines, -0 lines 0 comments Download
A cmd/godoc/throttle.go View 1 chunk +88 lines, -0 lines 0 comments Download
A cmd/godoc/utils.go View 1 chunk +91 lines, -0 lines 0 comments Download
A cmd/godoc/zip.go View 1 chunk +236 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
11 years, 9 months ago (2013-07-17 03:54:47 UTC) #1
bradfitz
LGTM On Wed, Jul 17, 2013 at 1:54 PM, <adg@golang.org> wrote: > Reviewers: bradfitz, > ...
11 years, 9 months ago (2013-07-17 04:01:16 UTC) #2
adg
11 years, 9 months ago (2013-07-17 04:02:45 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=3504d66cc4b6&repo=tools ***

go.tools/cmd/godoc: copy godoc from core reposistory

The plan for godoc:
- Copy godoc source from the core repo to go.tools (this CL).
- Break godoc into several packages inside go.tools, leaving a package
  main that merely sets up a local file system, interprets the command
  line, and otherwise delegates the heavy-lifting to the new packages.
- Remove godoc from the core repo.
- Update cmd/go to install this godoc binary in $GOROOT/bin.
- Update misc/dist to include godoc when building binary distributions.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/11408043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b