code review 11394043: go.talks/pkg/socket: set OMIT build tag when building p...

go.talks/pkg/socket: set OMIT build tag when building programs

This allows presentations to include the OMIT build tag
in code samples so that they aren't touched by "go install ./...".

[adg, 2013-07-16 23:48:29]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[dave_cheney.net, 2013-07-16 23:51:55]

LGTM.

On Wed, Jul 17, 2013 at 9:48 AM,  <adg@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.talks
>
>
> Description:
> go.talks/pkg/socket: set OMIT build tag when building programs
>
> This allows presentations to include the OMIT build tag
> in code samples so that they aren't touched by "go install ./...".
>
> Please review this at https://codereview.appspot.com/11394043/
>
> Affected files:
>   M pkg/socket/socket.go
>
>
> Index: pkg/socket/socket.go
> ===================================================================
> --- a/pkg/socket/socket.go
> +++ b/pkg/socket/socket.go
> @@ -173,7 +173,7 @@
>         // build x.go, creating x
>         p.bin = bin // to be removed by p.end
>         dir, file := filepath.Split(src)
> -       args := []string{"go", "build"}
> +       args := []string{"go", "build", "-tags", "OMIT"}
>         if opt != nil && opt.Race {
>                 p.out <- &Message{
>                         Id: p.id, Kind: "stderr",
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[r, 2013-07-17 00:31:02]

LGTM

[adg, 2013-07-17 00:35:14]

*** Submitted as
https://code.google.com/p/go/source/detail?r=d14fc3b04bd5&repo=talks ***

go.talks/pkg/socket: set OMIT build tag when building programs

This allows presentations to include the OMIT build tag
in code samples so that they aren't touched by "go install ./...".

R=r, dave
CC=golang-dev
https://codereview.appspot.com/11394043