Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(10607)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
113640043
: runtime: freemap
Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by
dvyukov
Modified:
9 years, 8 months ago
Reviewers:
Visibility:
Public.
Description
runtime: freemap
Patch Set 1
#
Patch Set 2 : diff -r 6125ea2b1dbf https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 3 : diff -r 6125ea2b1dbf https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 4 : diff -r b2131d729e52 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 5 : diff -r 163fae12c83b https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 6 : diff -r 8012587c5e3b https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 7 : diff -r dad4822bccff https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 8 : diff -r dad4822bccff https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 9 : diff -r dad4822bccff https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 10 : diff -r dad4822bccff https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 11 : diff -r dad4822bccff https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 12 : diff -r cf99a05f0fbc945aefe2acbf92a2d050ec58b6a1 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 13 : diff -r cf99a05f0fbc945aefe2acbf92a2d050ec58b6a1 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 14 : diff -r d50ba39e60ab3386cf126ea7df1bad5836295ca4 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 15 : diff -r d50ba39e60ab3386cf126ea7df1bad5836295ca4 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 16 : diff -r d50ba39e60ab3386cf126ea7df1bad5836295ca4 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 17 : diff -r 3b3e7fe70577b153f3c67532bbdc92f7312d7126 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 18 : diff -r 3b3e7fe70577b153f3c67532bbdc92f7312d7126 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 19 : diff -r 3b3e7fe70577b153f3c67532bbdc92f7312d7126 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 20 : diff -r e0bf1fc9dd8ed6029e45c9941d3f8dcce5ac9c8e https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 21 : diff -r 0104f35568767179a71719f728f8ee1da96aac16 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 22 : diff -r 0104f35568767179a71719f728f8ee1da96aac16 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 23 : diff -r 0104f35568767179a71719f728f8ee1da96aac16 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 24 : diff -r 55f09668f3b265c909e04580abec3ba84add2bae https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 25 : diff -r 601ad8b625532388ff9dee86409bf32c1f2f624a https://dvyukov%40google.com@code.google.com/p/go/
#
Created:
9 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+401 lines, -238 lines
)
Patch
M
src/pkg/runtime/heapdump.c
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
2 chunks
+4 lines, -3 lines
0 comments
Download
M
src/pkg/runtime/malloc.h
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
6 chunks
+16 lines, -12 lines
0 comments
Download
M
src/pkg/runtime/malloc.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
7 chunks
+124 lines, -45 lines
0 comments
Download
M
src/pkg/runtime/mcache.c
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
3 chunks
+45 lines, -20 lines
0 comments
Download
M
src/pkg/runtime/mcentral.c
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
9 chunks
+89 lines, -61 lines
0 comments
Download
M
src/pkg/runtime/mgc0.c
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
10 chunks
+107 lines, -80 lines
0 comments
Download
M
src/pkg/runtime/mheap.c
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
4 chunks
+6 lines, -7 lines
0 comments
Download
M
src/pkg/runtime/stack.c
View
1
20
21
22
23
24
2 chunks
+10 lines, -10 lines
0 comments
Download
Issue 113640043: runtime: freemap
Created 9 years, 9 months ago by dvyukov
Modified 9 years, 8 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
