Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1332)

Issue 113540044: code review 113540044: context: make parentCancelCtx iterative

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by abursavich
Modified:
9 years, 9 months ago
Reviewers:
Sameer Ajmani
CC:
golang-codereviews, Sameer Ajmani
Visibility:
Public.

Description

context: make parentCancelCtx iterative It seems like it was meant to be this way. There was already a for loop, but then it made a recursive call instead.

Patch Set 1 : diff -r 0075ecfeb3d8 https://code.google.com/p/go.net/ #

Patch Set 2 : diff -r 0075ecfeb3d8 https://code.google.com/p/go.net/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M context/context.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
abursavich
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com, sameer@golang.org), I'd like you to review this change to https://code.google.com/p/go.net/
9 years, 9 months ago (2014-07-31 23:19:39 UTC) #1
Sameer Ajmani
On 2014/07/31 23:19:39, abursavich wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: > mailto:golang-codereviews@googlegroups.com, mailto:sameer@golang.org), > > I'd ...
9 years, 9 months ago (2014-08-01 00:45:07 UTC) #2
Sameer Ajmani
On 2014/08/01 00:45:07, Sameer Ajmani wrote: > On 2014/07/31 23:19:39, abursavich wrote: > > Hello ...
9 years, 9 months ago (2014-08-01 13:35:10 UTC) #3
abursavich
On 2014/08/01 13:35:10, Sameer Ajmani wrote: > On 2014/08/01 00:45:07, Sameer Ajmani wrote: > > ...
9 years, 9 months ago (2014-08-01 14:25:52 UTC) #4
Sameer Ajmani
I may have to do something on my end. Will check into this later. On ...
9 years, 9 months ago (2014-08-01 14:27:00 UTC) #5
Sameer Ajmani
9 years, 9 months ago (2014-08-11 20:57:05 UTC) #6
*** Submitted as
https://code.google.com/p/go/source/detail?r=ad01a6fcc8a1&repo=net ***

context: make parentCancelCtx iterative

It seems like it was meant to be this way. There was already a for loop, but
then it made a recursive call instead.

LGTM=sameer
R=golang-codereviews, sameer
CC=golang-codereviews
https://codereview.appspot.com/113540044

Committer: Sameer Ajmani <sameer@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b