Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 11337043: code review 11337043: go.talks: use OMIT build tag to exclude example program... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by adg
Modified:
10 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, rsc, r
Visibility:
Public.

Description

go.talks: use OMIT build tag to exclude example programs from build They will still work with "go run x.go".

Patch Set 1 #

Patch Set 2 : diff -r d3c4a70757e8 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r d3c4a70757e8 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r d3c4a70757e8 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r d14fc3b04bd5 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r d14fc3b04bd5 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -26 lines) Patch
M 2010/io/balance.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2010/io/decrypt.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 2010/io/encrypt.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 2010/io/eval1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2010/io/eval2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2012/10things/10.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/10things/8.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/10things/9.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/10things/9b.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/chat/both/chat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/both/html.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/both/markov.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/http-noembed/chat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/http-noembed/html.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/http/chat.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/http/html.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/markov/chat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/markov/html.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/markov/markov.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/chan.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/defs.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/echo.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/echo-no-concurrency.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/embed.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/goroutines.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/hello.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/hello-net.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/hello-web.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/select.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/support/websocket.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/tcp-simple/chat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/chat/tcp/chat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/boring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/changoboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/chat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/daisy.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/faninboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/generator2boring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/generatorboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/goboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/google.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/google2.1.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/google2.2.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/google2.3.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/google3.0.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/helpers.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/lessboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/mainboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/quit.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/rcvquit.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/select.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/selectboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/sequenceboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/timeout.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/timeoutall.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/concurrency/support/waitgoboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/go-docs/faninboring.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/adder.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/cat.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/celsius.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/channels.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/communication1.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/communication2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/consts.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/decls.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/example0.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/example1.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/example2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/forloop.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/hello.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/interface.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/point.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/stmts.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/vars.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/worker1.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/goforc/worker2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/insidepresent/hello.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/insidepresent/socket.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/insidepresent/socket-simple.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2012/insidepresent/websocket.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2012/simple/flag.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/hello.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/hello-web.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/io/io.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/json.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/reader.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/test/string_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/time.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/time2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/time3.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/webfront/main.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/simple/webfront/server_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/1get.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/2json.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/3func.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/4method.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/hello.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/jsonserve.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/tutorial/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2012/tutorial/reddit/reddit.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/waza/balance.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2012/zen/hello.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/zen/http.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2012/zen/jsonformat.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2012/zen/race.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M 2013/advconc/buffer/buffer.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/dedupermain/dedupermain.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/fakemain/fakemain.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/naivemain/naivemain.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/nilselect/nilselect.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/pingpong/pingpong.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/pingpong1.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/pingpongdeadlock/pingpongdeadlock.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/pingpongpanic/pingpongpanic.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/advconc/realmain/realmain.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/chanof.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/intdiv.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/makefunc.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/methodvals.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/methodvals-old.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/race.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
R 2013/go1.1/reflect.go View 1 1 chunk +0 lines, -7 lines 0 comments Download
M 2013/go1.1/return.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/return-old.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/scanner.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/scanner2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/timer.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go1.1/yearday.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/highperf/longtail.go View 1 1 chunk +1 line, -1 line 0 comments Download
M 2013/highperf/mart/1/mart.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/highperf/mart/2/mart.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/highperf/mart/3/mart.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 8 months ago (2013-07-16 23:48:18 UTC) #1
rsc
Wait, what is the difference between OMIT and ignore?
10 years, 8 months ago (2013-07-17 00:02:42 UTC) #2
adg
On 17 July 2013 10:02, <rsc@golang.org> wrote: > Wait, what is the difference between OMIT ...
10 years, 8 months ago (2013-07-17 00:03:52 UTC) #3
rsc
LGTM then But I don't want to see OMIT in other contexts. Let's keep using ...
10 years, 8 months ago (2013-07-17 00:04:26 UTC) #4
adg
For sure. On 17 July 2013 10:04, Russ Cox <rsc@golang.org> wrote: > LGTM then > ...
10 years, 8 months ago (2013-07-17 00:05:45 UTC) #5
r
This was just an easy solution specific to the present tool. In hindsight, the present ...
10 years, 8 months ago (2013-07-17 00:32:20 UTC) #6
adg
On 17 July 2013 10:31, Rob Pike <r@golang.org> wrote: > This was just an easy ...
10 years, 8 months ago (2013-07-17 01:02:13 UTC) #7
adg
10 years, 8 months ago (2013-07-17 01:05:34 UTC) #8
*** Submitted as
https://code.google.com/p/go/source/detail?r=4eb3066a866f&repo=talks ***

go.talks: use OMIT build tag to exclude example programs from build

They will still work with "go run x.go".

R=golang-dev, rsc, r
CC=golang-dev
https://codereview.appspot.com/11337043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b