Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 113120043: code review 113120043: cmd/gc: implement 'for range x {' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rsc
Modified:
10 years, 8 months ago
Reviewers:
gri
CC:
ken2, r, gri, golang-codereviews
Visibility:
Public.

Description

cmd/gc: implement 'for range x {' Fixes issue 6102.

Patch Set 1 #

Patch Set 2 : diff -r 6866fbf95095 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6866fbf95095 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ab07d66858b6 https://code.google.com/p/go/ #

Patch Set 5 : diff -r ab07d66858b6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1435 lines, -1313 lines) Patch
M src/cmd/gc/esc.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/fmt.c View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/cmd/gc/go.y View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/gc/range.c View 1 8 chunks +33 lines, -15 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 76 chunks +1278 lines, -1284 lines 0 comments Download
M src/cmd/gc/yerr.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
M test/bench/shootout/chameneosredux.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/chan/perm.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug173.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/fixedbugs/bug406.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/range.go View 1 7 chunks +92 lines, -0 lines 0 comments Download
M test/stress/maps.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello ken2, r (cc: golang-codereviews@googlegroups.com, gri), I'd like you to review this change to https://code.google.com/p/go/
10 years, 8 months ago (2014-07-14 22:21:48 UTC) #1
rsc
I will wait until gofmt can process these go files before submitting.
10 years, 8 months ago (2014-07-14 22:22:07 UTC) #2
gri
LGTM but somebody more knowledgable than me should look at the gc changes. FYI, src/cmd/gc/y.tab.c ...
10 years, 8 months ago (2014-07-15 16:18:26 UTC) #3
rsc
On Tue, Jul 15, 2014 at 12:18 PM, <gri@golang.org> wrote: > LGTM > > but ...
10 years, 8 months ago (2014-07-15 16:43:44 UTC) #4
rsc
10 years, 8 months ago (2014-07-16 23:27:14 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=6f69b178e6d9 ***

cmd/gc: implement 'for range x {'

Fixes issue 6102.

LGTM=gri
R=ken, r, gri
CC=golang-codereviews
https://codereview.appspot.com/113120043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b