Issue 112900044: net/http/cgi: attempt to determine the remote port befo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112900044: net/http/cgi: attempt to determine the remote port befo...

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by georgyo

Modified:
9 years, 10 months ago

Reviewers:

Visibility:
Public.

Description

net/http/cgi: attempt to determine the remote port before defaulting Some CGI servers correctly pass down the REMOTE_PORT environment variable. However the however cgi package hard codes the port to zero. It should first check if it has the REMOTE_PORT param before defaulting to zero.

Patch Set 1 #

Patch Set 2 : diff -r 0935b17aebed https://code.google.com/p/go/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/pkg/net/http/cgi/child.go	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download