Issue 11275043: code review 11275043: go.talks/2010: add missing image file and fix typo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11275043: code review 11275043: go.talks/2010: add missing image file and fix typo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by chai2010

Modified:
10 years, 9 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

go.talks/2010: add missing image file and fix typo. Fixes issue 5889.

Patch Set 2 : diff -r 018a73a768a5 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 018a73a768a5 https://code.google.com/p/go.talks #

Total comments: 2

Patch Set 4 : diff -r 018a73a768a5 https://code.google.com/p/go.talks #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
A	2010/go-logo-white.png	View	1	Binary file		0 comments	Download
M	2010/go_talk-20100112.html	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	2010/go_talk-20100121.html	View	1 2 3	7 chunks	+8 lines, -8 lines	0 comments	Download
M	2010/go_talk-20100323.html	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
A	2010/gordon/bumper480x270.png	View	1	Binary file		0 comments	Download
A	2010/gordon/bumper640x360.png	View	1	Binary file		0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

chai2010

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

10 years, 9 months ago (2013-07-15 13:16:35 UTC) #1

adg

https://codereview.appspot.com/11275043/diff/9001/2010/go_talk-20100121.html File 2010/go_talk-20100121.html (right): https://codereview.appspot.com/11275043/diff/9001/2010/go_talk-20100121.html#newcode27 2010/go_talk-20100121.html:27: <img src="./gordon/bumper480x270.png" style="margin: -135px 0 0 0;"/> remove the ...

10 years, 9 months ago (2013-07-16 06:44:21 UTC) #2

chai2010

PTAL https://codereview.appspot.com/11275043/diff/9001/2010/go_talk-20100121.html File 2010/go_talk-20100121.html (right): https://codereview.appspot.com/11275043/diff/9001/2010/go_talk-20100121.html#newcode27 2010/go_talk-20100121.html:27: <img src="./gordon/bumper480x270.png" style="margin: -135px 0 0 0;"/> On ...

10 years, 9 months ago (2013-07-16 06:53:40 UTC) #3

adg

10 years, 9 months ago (2013-07-16 06:57:15 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=cd9935f063c6&repo=talks ***

go.talks/2010: add missing image file and fix typo.

Fixes issue 5889.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/11275043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages