code review 112530043: include/u.h: define _DEFAULT_SOURCE for new glibc

include/u.h: define _DEFAULT_SOURCE for new glibc

glibc devs have apparently decided _BSD_SOURCE will be
deprecated on Linux, and issue a preprocessor warning if
declaring _BSD_SOURCE without _DEFAULT_SOURCE.

https://sourceware.org/glibc/wiki/Release/2.20

Fixes issue 8397.

[dave_cheney.net, 2014-07-21 11:03:02]

Please hg mail 112530043 this to start the review process.

[bpowers, 2014-07-21 12:48:30]

Hello dave@cheney.net (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2014-07-21 21:26:04]

R=iant@golang.org (assigned by dave@cheney.net)

[bpowers, 2014-07-25 13:20:40]

On 2014/07/21 21:26:04, gobot wrote:
> mailto:R=iant@golang.org (assigned by mailto:dave@cheney.net)

ping.  Thoughts Ian?

[iant, 2014-07-25 15:49:23]

LGTM

[iant, 2014-07-25 15:54:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=c8059ac4e0ec ***

include/u.h: define _DEFAULT_SOURCE for new glibc

glibc devs have apparently decided _BSD_SOURCE will be
deprecated on Linux, and issue a preprocessor warning if
declaring _BSD_SOURCE without _DEFAULT_SOURCE.

https://sourceware.org/glibc/wiki/Release/2.20

Fixes issue 8397.

LGTM=iant
R=dave, gobot, iant
CC=golang-codereviews
https://codereview.appspot.com/112530043

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-07-25 16:03:02]

This CL appears to have broken the darwin-amd64-cheney builder.
See http://build.golang.org/log/1dd4df310fe90ef42be5eddf018bb1d519cc3229

[iant, 2014-07-25 16:19:46]

On Fri, Jul 25, 2014 at 9:03 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-amd64-cheney builder.
> See http://build.golang.org/log/1dd4df310fe90ef42be5eddf018bb1d519cc3229
>
> https://codereview.appspot.com/112530043/

Does not appear to be related.  I hope.

--- FAIL: TestRepoRootForImportPath (10.42s)
vcs_test.go:114: RepoRootForImport("code.google.com/p/go"):
https://code.google.com/p/go/source/checkout?repo=: 500 Internal
Server Error
FAIL
FAIL cmd/go 10.522s

Ian

[bpowers, 2014-07-25 20:16:50]

On 2014/07/25 16:19:46, iant wrote:
> Does not appear to be related.  I hope.

Can we kickoff a rebuild on that builder?