Issue 112320043: objdump: remove out-of-date comment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112320043: objdump: remove out-of-date comment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by mdempsky

Modified:
10 years, 7 months ago

Reviewers:
gobot, iant

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r 14ce03206cbd https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	src/cmd/objdump/main.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mdempsky

I believe this comment no longer applies after https://codereview.appspot.com/104770046.

10 years, 8 months ago (2014-07-15 07:47:33 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=fa761009af4c *** objdump: remove out-of-date comment LGTM=iant R=rsc, iant CC=golang-codereviews https://codereview.appspot.com/112320043 Committer: ...

10 years, 8 months ago (2014-07-15 13:03:42 UTC) #3

gobot

10 years, 8 months ago (2014-07-15 13:14:40 UTC) #4

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/d1dac641ef3113e5033a3bfc45fd6970e65b392a

Expand All Messages | Collapse All Messages