Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(872)

Issue 11200044: code review 11200044: go.talks/pkg/socket: fix go-tour non-main package wrong... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by chai2010
Modified:
10 years, 8 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

go.talks/pkg/socket: fix go-tour non-main package wrong message Fixes issue 5871.

Patch Set 1 #

Patch Set 2 : diff -r 066b009fee9d https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 066b009fee9d https://code.google.com/p/go.talks #

Total comments: 2

Patch Set 4 : diff -r 066b009fee9d https://code.google.com/p/go.talks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M pkg/socket/socket.go View 1 2 3 4 chunks +17 lines, -0 lines 1 comment Download

Messages

Total messages: 4
chai2010
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 8 months ago (2013-07-12 03:08:58 UTC) #1
adg
No need to shell out to the go tool again. Just import "go/parser" and "go/token", ...
10 years, 8 months ago (2013-07-12 04:09:44 UTC) #2
chai2010
Please take another look. https://codereview.appspot.com/11200044/diff/6001/pkg/socket/socket.go File pkg/socket/socket.go (right): https://codereview.appspot.com/11200044/diff/6001/pkg/socket/socket.go#newcode198 pkg/socket/socket.go:198: return err On 2013/07/12 04:09:44, ...
10 years, 8 months ago (2013-07-12 04:43:53 UTC) #3
adg
10 years, 8 months ago (2013-07-15 02:13:58 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=018a73a768a5&repo=talks ***

go.talks/pkg/socket: fix go-tour non-main package wrong message

Fixes issue 5871.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/11200044

Committer: Andrew Gerrand <adg@golang.org>

https://codereview.appspot.com/11200044/diff/12001/pkg/socket/socket.go
File pkg/socket/socket.go (right):

https://codereview.appspot.com/11200044/diff/12001/pkg/socket/socket.go#newco...
pkg/socket/socket.go:160: if name, err := packageName(body); err == nil && name
!= "main" {
I move this to inside the execution error check
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b