Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(624)

Issue 11151043: code review 11151043: go.talks/present: simplify rendering of in-line links. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by r
Modified:
10 years, 9 months ago
Reviewers:
adg, rsc
CC:
adg, golang-dev
Visibility:
Public.

Description

go.talks/present: simplify rendering of in-line links. If one writes [[http://golang.org]] drop the http:// from the presented text. Otherwise we need to write [[http://golang.org][golang.org]] which is stuttery.

Patch Set 1 #

Patch Set 2 : diff -r b3cad5151b4a https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M 2012/splash.article View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/present/link.go View 2 chunks +17 lines, -5 lines 0 comments Download
M pkg/present/link_test.go View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/present/style_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 9 months ago (2013-07-11 06:41:21 UTC) #1
adg
LGTM
10 years, 9 months ago (2013-07-11 06:44:09 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=4828eb18975e&repo=talks *** go.talks/present: simplify rendering of in-line links. If one writes [[http://golang.org]] ...
10 years, 9 months ago (2013-07-11 06:50:59 UTC) #3
rsc
Why is the http:// required?
10 years, 9 months ago (2013-07-12 02:15:21 UTC) #4
adg
10 years, 9 months ago (2013-07-12 02:25:31 UTC) #5
To support relative path links.
On 12 Jul 2013 12:15, "Russ Cox" <rsc@golang.org> wrote:

> Why is the http:// required?
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b