Issue 110980044: code review 110980044: cmd/gc: generate type alg after calling dowidth.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110980044: code review 110980044: cmd/gc: generate type alg after calling dowidth. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by remyoudompheng

Modified:
9 years, 7 months ago

Reviewers:
rsc, dvyukov

CC:
golang-codereviews, dvyukov, gobot, rsc

Visibility:
Public.

Description

cmd/gc: generate type alg after calling dowidth. Previously it might happen before calling dowidth and result in a compiler crash. Fixes issue 8060.

Patch Set 1 #

Patch Set 2 : diff -r 0935b17aebed https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0935b17aebed https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 938ecc995cbca35db65ef45c0276720bc5349036 https://go.googlecode.com/hg/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
M	src/cmd/gc/reflect.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A	test/fixedbugs/issue8060.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue8060.dir/a.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue8060.dir/b.go	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 10 months ago (2014-07-09 21:53:59 UTC) #1

dvyukov

nice LGTM the compiler is closed, so wait for Russ I guess

9 years, 10 months ago (2014-07-10 07:33:06 UTC) #2

remyoudompheng

9 years, 7 months ago (2014-09-15 16:24:22 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=d187e2797b7b ***

cmd/gc: generate type alg after calling dowidth.

Previously it might happen before calling dowidth and
result in a compiler crash.

Fixes issue 8060.

LGTM=dvyukov, rsc
R=golang-codereviews, dvyukov, gobot, rsc
CC=golang-codereviews
https://codereview.appspot.com/110980044

Expand All Messages | Collapse All Messages