Issue 11034043: code review 11034043: go-tour: add missing error/rune predeclared identifier ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11034043: code review 11034043: go-tour: add missing error/rune predeclared identifier ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by chai2010

Modified:
10 years, 10 months ago

Reviewers:
adg

CC:
golang-dev, khr, adg

Visibility:
Public.

Description

go-tour: add missing error/rune predeclared identifier for Syntax-Highlighting

Patch Set 1 #

Patch Set 2 : diff -r ed7b2c35755e https://code.google.com/p/go-tour #

Patch Set 3 : diff -r ed7b2c35755e https://code.google.com/p/go-tour #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	js/codemirror/lib/go.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

chai2010

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 10 months ago (2013-07-09 06:59:54 UTC) #1

chai2010

On 2013/07/09 06:59:54, chai2010 wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

10 years, 10 months ago (2013-07-17 01:28:50 UTC) #2

adg

10 years, 10 months ago (2013-07-23 04:16:29 UTC) #5

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=de629fc566eb
***

go-tour: add missing error/rune predeclared identifier for Syntax-Highlighting

R=golang-dev, khr, adg
CC=golang-dev
https://codereview.appspot.com/11034043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages