code review 11012046: go.talks/pkg/socket: fix go-tour non-main package wrong...

go.talks/pkg/socket: fix can't remove temp binary issue

Fixes issue 5870.

[chai2010, 2013-07-11 23:54:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2013-07-12 00:02:42]

Using "go run" is wrong. It breaks "kill".

Please reduce this CL to just the code concerning os.Remove(bin)

https://codereview.appspot.com/11012046/diff/4001/pkg/socket/socket.go
File pkg/socket/socket.go (right):

https://codereview.appspot.com/11012046/diff/4001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:192: // given error value.
Update the comment; it also removes the binary.

[chai2010, 2013-07-12 00:20:14]

sorry for the "go run" change.
I will send a new CL for issue5871 later.

right now, this CL is just for issue5870.

https://codereview.appspot.com/11012046/diff/4001/pkg/socket/socket.go
File pkg/socket/socket.go (right):

https://codereview.appspot.com/11012046/diff/4001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:192: // given error value.
On 2013/07/12 00:02:42, adg wrote:
> Update the comment; it also removes the binary.

Done.

[adg, 2013-07-12 00:46:29]

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go
File pkg/socket/socket.go (right):

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:120: tmpBin string
s/tmpBin/bin

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:161: p.tmpBin = bin
move this to after the call to WriteFile

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:207: // given error value. it also removes the binary.
s/it/It/

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:209: if p.tmpBin != "" {
p.bin

[chai2010, 2013-07-12 01:10:53]

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go
File pkg/socket/socket.go (right):

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:120: tmpBin string
On 2013/07/12 00:46:29, adg wrote:
> s/tmpBin/bin

Done.

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:161: p.tmpBin = bin
On 2013/07/12 00:46:29, adg wrote:
> move this to after the call to WriteFile

Done.

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:207: // given error value. it also removes the binary.
On 2013/07/12 00:46:29, adg wrote:
> s/it/It/

Done.

https://codereview.appspot.com/11012046/diff/9001/pkg/socket/socket.go#newcod...
pkg/socket/socket.go:209: if p.tmpBin != "" {
On 2013/07/12 00:46:29, adg wrote:
> p.bin

Done.

[adg, 2013-07-12 01:13:46]

LGTM

[adg, 2013-07-12 01:15:40]

*** Submitted as
https://code.google.com/p/go/source/detail?r=066b009fee9d&repo=talks ***

go.talks/pkg/socket: fix can't remove temp binary issue

Fixes issue 5870.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/11012046

Committer: Andrew Gerrand <adg@golang.org>