Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(211)

Issue 11011043: code review 11011043: go.tools/ssa: avoid redundant uint64 conversion of righ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by adonovan
Modified:
10 years, 6 months ago
Reviewers:
gri
CC:
golang-dev, gri
Visibility:
Public.

Description

go.tools/ssa: avoid redundant uint64 conversion of right operand of <<, >>. Also: add sanity check that no Instruction yields a Value of 'untyped' type.

Patch Set 1 #

Patch Set 2 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Patch Set 4 : code review 11011043: go.tools/ssa: avoid redundant uint64 conversion of righ... #

Patch Set 5 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Patch Set 6 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Patch Set 7 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 8 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 9 : diff -r 088133ed831d https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M ssa/emit.go View 1 2 4 1 chunk +0 lines, -1 line 0 comments Download
M ssa/interp/ops.go View 1 4 3 chunks +2 lines, -22 lines 0 comments Download
M ssa/interp/testdata/coverage.go View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M ssa/sanity.go View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 6
adonovan
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 8 months ago (2013-07-08 21:02:53 UTC) #1
gri
https://codereview.appspot.com/11011043/diff/15001/ssa/sanity.go File ssa/sanity.go (right): https://codereview.appspot.com/11011043/diff/15001/ssa/sanity.go#newcode163 ssa/sanity.go:163: // Check value-defining instructions have valid types. what about ...
10 years, 8 months ago (2013-07-08 21:15:12 UTC) #2
adonovan
https://codereview.appspot.com/11011043/diff/15001/ssa/sanity.go File ssa/sanity.go (right): https://codereview.appspot.com/11011043/diff/15001/ssa/sanity.go#newcode163 ssa/sanity.go:163: // Check value-defining instructions have valid types. On 2013/07/08 ...
10 years, 8 months ago (2013-07-08 21:29:26 UTC) #3
gri
LGTM https://codereview.appspot.com/11011043/diff/5005/ssa/sanity.go File ssa/sanity.go (right): https://codereview.appspot.com/11011043/diff/5005/ssa/sanity.go#newcode163 ssa/sanity.go:163: // Check value-defining instructions have valid types. // ...
10 years, 8 months ago (2013-07-08 21:32:12 UTC) #4
adonovan
*** Submitted as https://code.google.com/p/go/source/detail?r=7c66da902422&repo=tools *** go.tools/ssa: avoid redundant uint64 conversion of right operand of <<, ...
10 years, 8 months ago (2013-07-08 21:33:54 UTC) #5
adonovan
10 years, 6 months ago (2013-09-04 14:14:55 UTC) #6
Message was sent while issue was closed.
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b