Issue 110040043: code review 110040043: [release-branch.go1.3] fmt: fix signs when zero padding.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110040043: code review 110040043: [release-branch.go1.3] fmt: fix signs when zero padding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by adg

Modified:
9 years, 10 months ago

Reviewers:
r, rsc

CC:
r, rsc, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] fmt: fix signs when zero padding. ««« CL 103480043 / 777dd5a434db fmt: fix signs when zero padding. Bug was introduced recently. Add more tests, fix the bugs. Suppress + sign when not required in zero padding. Do not zero pad infinities. All old tests still pass. This time for sure! Fixes issue 8217. LGTM=rsc R=golang-codereviews, dan.kortschak, rsc CC=golang-codereviews https://codereview.appspot.com/103480043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 4db9bc6775ea https://code.google.com/p/go #

Patch Set 3 : diff -r 7ec493c7f2bf https://code.google.com/p/go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -43 lines)			Patch
	M	src/pkg/fmt/fmt_test.go	View	1	2 chunks	+113 lines, -2 lines	0 comments	Download
	M	src/pkg/fmt/format.go	View	1	2 chunks	+38 lines, -41 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 10 months ago (2014-06-18 01:25:11 UTC) #1

adg

9 years, 10 months ago (2014-06-18 23:54:17 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6b9d2b9bb54e ***

[release-branch.go1.3] fmt: fix signs when zero padding.

««« CL 103480043 / 777dd5a434db
fmt: fix signs when zero padding.
Bug was introduced recently. Add more tests, fix the bugs.
Suppress + sign when not required in zero padding.
Do not zero pad infinities.
All old tests still pass.
This time for sure!
Fixes issue 8217.

LGTM=rsc
R=golang-codereviews, dan.kortschak, rsc
CC=golang-codereviews
https://codereview.appspot.com/103480043
»»»

LGTM=r, rsc
R=r, rsc
CC=golang-codereviews
https://codereview.appspot.com/110040043

Expand All Messages | Collapse All Messages