Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(906)

Issue 109920044: code review 109920044: runtime: fix runtime.jmpdefer properly for 1.4.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by minux
Modified:
9 years, 8 months ago
Reviewers:
rsc, dfc, elias.naur
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: fix runtime.jmpdefer properly for 1.4. See CL 107970043 for rationale. Fixes issue 8153.

Patch Set 1 #

Patch Set 2 : diff -r 83e5cc3f003d https://code.google.com/p/go #

Patch Set 3 : diff -r 83e5cc3f003d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/pkg/runtime/asm_arm.s View 1 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 4
minux
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-06-12 20:55:05 UTC) #1
elias.naur
On 2014/06/12 20:55:05, minux wrote: > Hello mailto:rsc@golang.org (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
9 years, 9 months ago (2014-06-13 08:51:03 UTC) #2
dfc
ping
9 years, 8 months ago (2014-07-21 10:14:48 UTC) #3
minux
9 years, 8 months ago (2014-07-22 02:59:28 UTC) #4
R=close
Russ NOT LGTMed this CL, but that mail failed to make it to rietveld.

From: Russ Cox
Date: Fri, Jun 13, 2014 at 11:20 AM
Subject: Re: code review 109920044: runtime: fix runtime.jmpdefer properly for
1.4. (issue 109920044 by minux)
To: Shenghou Ma, Russ Cox, Elias Naur, "golang-codereviews",
"reply@codereview-hr.appspotmail.com"

not lgtm

Per our offline discussion yesterday, we're not going to do this. It will make
the NaCl port more complex, and honestly it's a bit scary anyway, and it only
affects something like in 1 in 1000 profile samples. The statistics are not
invalidated by discarding that 1 sample. If we find some other reason this is
important, we can come back to it.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b