Issue 1098041: code review 1098041: math: signed zero Sqrt special case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1098041: code review 1098041: math: signed zero Sqrt special case (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by Charlie Dorian

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

math: signed zero Sqrt special case IEEE 754 says: sqrt(-0) = -0

Patch Set 1 #

Patch Set 2 : code review 1098041: math: signed zero Sqrt special case #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
M	src/pkg/math/all_test.go	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	src/pkg/math/sqrt.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/math/sqrt_port.go	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-05-04 17:16:17 UTC) #1

On May 4, 2010, at 10:16 AM, cldorian@gmail.com wrote: > IEEE 754 says: sqrt(-0) = ...

14 years, 11 months ago (2010-05-04 17:17:16 UTC) #2

Charlie Dorian

Yes, it astonished me, too. And most wonderful, the assembly functions needed no change! On ...

14 years, 11 months ago (2010-05-04 17:43:18 UTC) #3

rsc

14 years, 10 months ago (2010-05-19 05:16:09 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=075486a1e563 ***

math: signed zero Sqrt special case

IEEE 754 says: sqrt(-0) = -0

R=rsc
CC=golang-dev
http://codereview.appspot.com/1098041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages