code review 109500043: encoding/xml: respect omitempty and don't crash on empt...

encoding/xml: respect omitempty and don't crash on empty non-string values.

Fixes issue 8333 and issue 8334.

[oneofone, 2014-07-07 03:23:47]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2014-07-07 04:16:06]

On 2014/07/07 03:23:47, oneofone wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Thanks for proposing this. Please add a test so we know that this issue won't
regress in the future.

[oneofone, 2014-07-07 04:37:15]

Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[oneofone, 2014-07-07 04:48:50]

Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[gobot, 2014-12-19 05:10:15]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/109500043 is best) in the description in your
new CL.

Thanks very much.