code review 1094043: release.2010-05-04

release.2010-05-04

[adg, 2010-05-05 01:30:05]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri1, 2010-05-05 02:05:11]

There were also (at least one) clarifications in the spec (one from today),
albeit no language changes. Not sure if you have mentioned those in the
past.
- Robert

On Tue, May 4, 2010 at 6:30 PM, <adg@golang.org> wrote:

> Reviewers: r, rsc,
>
> Message:
> Hello r, rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> release.2010-05-04
>
> Please review this at http://codereview.appspot.com/1094043/show
>
> Affected files:
>  M .hgtags
>  M doc/devel/release.html
>
>
> Index: .hgtags
> ===================================================================
> --- a/.hgtags
> +++ b/.hgtags
> @@ -18,4 +18,3 @@
>  57380d620ee6b65eb88da1c52784b62c94d7e72e release.2010-03-30
>  f98f784927abc56a61501eba0cf225966f2b0142 release.2010-04-13
>  6cc6c0d85fc3234fc0a5ec0a8777aa9d59d05ae8 release.2010-04-27
> -6cc6c0d85fc3234fc0a5ec0a8777aa9d59d05ae8 release
> Index: doc/devel/release.html
> ===================================================================
> --- a/doc/devel/release.html
> +++ b/doc/devel/release.html
> @@ -5,6 +5,33 @@
>  <p>This page summarizes the changes between tagged releases of Go.
>  For full details, see the <a href="
> http://code.google.com/p/go/source/list">Mercurial change log</a>.</p>
>
> +<h3 id="2010-05-04">2010-05-04</h3>
> +
> +<pre>
> +In this release we renamed the Windows OS target from 'mingw' to
> 'windows'.
> +If you are currently building for 'mingw' you should set GOOS=windows
> instead.
> +
> +* 5l, 6l, 8l, runtime: make -s binaries work.
> +* 5l, 6l, 8l: change ELF header so that strip doesn't destroy binary.
> +* 8l: fix absolute path detection on Windows.
> +* big: new functions, optimizations, and cleanups,
> +       add bitwise methods for Int (thanks Evan Shaw).
> +* bytes: Change IndexAny to look for UTF-8 encoded characters.
> +* darwin: bsdthread_create can fail; print good error.
> +* fmt: %Tmissing print <nil> for nil (thanks Christopher Wedgwood).
> +* gc: many fixes.
> +* misc/cgo/gmp: fix bug in SetString.
> +* net: fix resolv.conf EOF without newline bug (thanks Christopher
> Wedgwood).
> +* syscall: add EWOULDBLOCK to sycall_nacl.go,
> +       force O_LARGEFILE in Linux open system call,
> +       handle EOF on pipe - special case on Windows (thanks Alex
> Brainman),
> +       mingw Sleep (thanks Joe Poirier).
> +* test/bench: import new fasta C reference, update Go, optimizations.
> +* test: test of static initialization (fails).
> +* vector: use correct capacity in call to make.
> +* xml: allow text segments to end at EOF.
> +</pre>
> +
>  <h3 id="2010-04-27">2010-04-27</h3>
>
>  <pre>
>
>
>

[rsc, 2010-05-05 02:06:29]

LGTM

s/%Tmissing/%T missing/

[adg, 2010-05-05 02:09:45]

I didn't include it because it doesn't have any implications as to the
way people write code (a lot of internal implementation changes get
dropped from this list also).

On 5 May 2010 12:05, Robert Griesemer <gri@google.com> wrote:
> There were also (at least one) clarifications in the spec (one from today),
> albeit no language changes. Not sure if you have mentioned those in the
> past.
> - Robert
>
> On Tue, May 4, 2010 at 6:30 PM, <adg@golang.org> wrote:
>>
>> Reviewers: r, rsc,
>>
>> Message:
>> Hello r, rsc (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change.
>>
>>
>> Description:
>> release.2010-05-04
>>
>> Please review this at http://codereview.appspot.com/1094043/show
>>
>> Affected files:
>>  M .hgtags
>>  M doc/devel/release.html
>>
>>
>> Index: .hgtags
>> ===================================================================
>> --- a/.hgtags
>> +++ b/.hgtags
>> @@ -18,4 +18,3 @@
>>  57380d620ee6b65eb88da1c52784b62c94d7e72e release.2010-03-30
>>  f98f784927abc56a61501eba0cf225966f2b0142 release.2010-04-13
>>  6cc6c0d85fc3234fc0a5ec0a8777aa9d59d05ae8 release.2010-04-27
>> -6cc6c0d85fc3234fc0a5ec0a8777aa9d59d05ae8 release
>> Index: doc/devel/release.html
>> ===================================================================
>> --- a/doc/devel/release.html
>> +++ b/doc/devel/release.html
>> @@ -5,6 +5,33 @@
>>  <p>This page summarizes the changes between tagged releases of Go.
>>  For full details, see the <a
>> href="http://code.google.com/p/go/source/list">Mercurial change log</a>.</p>
>>
>> +<h3 id="2010-05-04">2010-05-04</h3>
>> +
>> +<pre>
>> +In this release we renamed the Windows OS target from 'mingw' to
>> 'windows'.
>> +If you are currently building for 'mingw' you should set GOOS=windows
>> instead.
>> +
>> +* 5l, 6l, 8l, runtime: make -s binaries work.
>> +* 5l, 6l, 8l: change ELF header so that strip doesn't destroy binary.
>> +* 8l: fix absolute path detection on Windows.
>> +* big: new functions, optimizations, and cleanups,
>> +       add bitwise methods for Int (thanks Evan Shaw).
>> +* bytes: Change IndexAny to look for UTF-8 encoded characters.
>> +* darwin: bsdthread_create can fail; print good error.
>> +* fmt: %Tmissing print <nil> for nil (thanks Christopher Wedgwood).
>> +* gc: many fixes.
>> +* misc/cgo/gmp: fix bug in SetString.
>> +* net: fix resolv.conf EOF without newline bug (thanks Christopher
>> Wedgwood).
>> +* syscall: add EWOULDBLOCK to sycall_nacl.go,
>> +       force O_LARGEFILE in Linux open system call,
>> +       handle EOF on pipe - special case on Windows (thanks Alex
>> Brainman),
>> +       mingw Sleep (thanks Joe Poirier).
>> +* test/bench: import new fasta C reference, update Go, optimizations.
>> +* test: test of static initialization (fails).
>> +* vector: use correct capacity in call to make.
>> +* xml: allow text segments to end at EOF.
>> +</pre>
>> +
>>  <h3 id="2010-04-27">2010-04-27</h3>
>>
>>  <pre>
>>
>>
>
>

[adg, 2010-05-05 02:12:11]

*** Submitted as http://code.google.com/p/go/source/detail?r=17ded5ad443b ***

release.2010-05-04

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1094043

[adg, 2010-05-05 02:15:07]

I decided to include a note:
* spec: some small clarifications. (no language changes)

On 5 May 2010 12:09, Andrew Gerrand <adg@golang.org> wrote:
> I didn't include it because it doesn't have any implications as to the
> way people write code (a lot of internal implementation changes get
> dropped from this list also).
>
> On 5 May 2010 12:05, Robert Griesemer <gri@google.com> wrote:
>> There were also (at least one) clarifications in the spec (one from today),
>> albeit no language changes. Not sure if you have mentioned those in the
>> past.
>> - Robert
>>
>> On Tue, May 4, 2010 at 6:30 PM, <adg@golang.org> wrote:
>>>
>>> Reviewers: r, rsc,
>>>
>>> Message:
>>> Hello r, rsc (cc: golang-dev@googlegroups.com),
>>>
>>> I'd like you to review this change.
>>>
>>>
>>> Description:
>>> release.2010-05-04
>>>
>>> Please review this at http://codereview.appspot.com/1094043/show
>>>
>>> Affected files:
>>>  M .hgtags
>>>  M doc/devel/release.html
>>>
>>>
>>> Index: .hgtags
>>> ===================================================================
>>> --- a/.hgtags
>>> +++ b/.hgtags
>>> @@ -18,4 +18,3 @@
>>>  57380d620ee6b65eb88da1c52784b62c94d7e72e release.2010-03-30
>>>  f98f784927abc56a61501eba0cf225966f2b0142 release.2010-04-13
>>>  6cc6c0d85fc3234fc0a5ec0a8777aa9d59d05ae8 release.2010-04-27
>>> -6cc6c0d85fc3234fc0a5ec0a8777aa9d59d05ae8 release
>>> Index: doc/devel/release.html
>>> ===================================================================
>>> --- a/doc/devel/release.html
>>> +++ b/doc/devel/release.html
>>> @@ -5,6 +5,33 @@
>>>  <p>This page summarizes the changes between tagged releases of Go.
>>>  For full details, see the <a
>>> href="http://code.google.com/p/go/source/list">Mercurial change log</a>.</p>
>>>
>>> +<h3 id="2010-05-04">2010-05-04</h3>
>>> +
>>> +<pre>
>>> +In this release we renamed the Windows OS target from 'mingw' to
>>> 'windows'.
>>> +If you are currently building for 'mingw' you should set GOOS=windows
>>> instead.
>>> +
>>> +* 5l, 6l, 8l, runtime: make -s binaries work.
>>> +* 5l, 6l, 8l: change ELF header so that strip doesn't destroy binary.
>>> +* 8l: fix absolute path detection on Windows.
>>> +* big: new functions, optimizations, and cleanups,
>>> +       add bitwise methods for Int (thanks Evan Shaw).
>>> +* bytes: Change IndexAny to look for UTF-8 encoded characters.
>>> +* darwin: bsdthread_create can fail; print good error.
>>> +* fmt: %Tmissing print <nil> for nil (thanks Christopher Wedgwood).
>>> +* gc: many fixes.
>>> +* misc/cgo/gmp: fix bug in SetString.
>>> +* net: fix resolv.conf EOF without newline bug (thanks Christopher
>>> Wedgwood).
>>> +* syscall: add EWOULDBLOCK to sycall_nacl.go,
>>> +       force O_LARGEFILE in Linux open system call,
>>> +       handle EOF on pipe - special case on Windows (thanks Alex
>>> Brainman),
>>> +       mingw Sleep (thanks Joe Poirier).
>>> +* test/bench: import new fasta C reference, update Go, optimizations.
>>> +* test: test of static initialization (fails).
>>> +* vector: use correct capacity in call to make.
>>> +* xml: allow text segments to end at EOF.
>>> +</pre>
>>> +
>>>  <h3 id="2010-04-27">2010-04-27</h3>
>>>
>>>  <pre>
>>>
>>>
>>
>>
>