Issue 10933043: code review 10933043: go-tour: update to use new playground.js

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10933043: code review 10933043: go-tour: update to use new playground.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adg

Modified:
10 years, 10 months ago

Reviewers:
dsymonds

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

go-tour: update to use new playground.js

Patch Set 2 : diff -r 666819953a0f https://code.google.com/p/go-tour #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+429 lines, -200 lines)			Patch
M	gotour/appengine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gotour/local.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gotour/tour.go	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	js/playground.js	View		1 chunk	+402 lines, -95 lines	0 comments	Download
R	js/socket.js	View		1 chunk	+0 lines, -81 lines	0 comments	Download
M	js/tour.js	View		3 chunks	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 10 months ago (2013-07-04 03:46:36 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/10933043/diff/1/gotour/tour.go File gotour/tour.go (right): https://codereview.appspot.com/10933043/diff/1/gotour/tour.go#newcode91 gotour/tour.go:91: func serveScripts(root string, transport string) error { (root, ...

10 years, 10 months ago (2013-07-04 03:50:33 UTC) #2

adg

10 years, 10 months ago (2013-07-04 03:52:26 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=04919a361ac3
***

go-tour: update to use new playground.js

R=dsymonds
CC=golang-dev
https://codereview.appspot.com/10933043

Expand All Messages | Collapse All Messages