code review 109010043: go.image/vp8l: new package.

go.image/vp8l: new package.

The blue-purple-pink image comes from
http://blog.golang.org/gophercon

The tux and yellow_rose images come from
https://developers.google.com/speed/webp/gallery2 and according to
that page, those images are in the public domain.

The gopher-doc images are http://golang.org/doc/gopher/doc.png
after quantizing its palette to 2/4/16/256 colors.

[nigeltao, 2014-06-15 12:36:58]

Hello r@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.image

[r, 2014-06-16 20:07:37]

LGTM

https://codereview.appspot.com/109010043/diff/40001/vp8l/decode.go
File vp8l/decode.go (right):

https://codereview.appspot.com/109010043/diff/40001/vp8l/decode.go#newcode199
vp8l/decode.go:199: return errors.New("vp8l: invalid code lengths")
another error you could reuse

https://codereview.appspot.com/109010043/diff/40001/vp8l/huffman.go
File vp8l/huffman.go (right):

https://codereview.appspot.com/109010043/diff/40001/vp8l/huffman.go#newcode91
vp8l/huffman.go:91: return errors.New("vp8l: invalid Huffman tree")
define this error once

https://codereview.appspot.com/109010043/diff/40001/vp8l/huffman.go#newcode160
vp8l/huffman.go:160: return errors.New("vp8l: invalid Huffman tree")
see, it's everywhere

https://codereview.appspot.com/109010043/diff/40001/vp8l/transform.go
File vp8l/transform.go (right):

https://codereview.appspot.com/109010043/diff/40001/vp8l/transform.go#newcode16
vp8l/transform.go:16: transformTypePredictor     = 0
you could use iota here

[nigeltao, 2014-06-17 11:49:40]

https://codereview.appspot.com/109010043/diff/40001/vp8l/decode.go
File vp8l/decode.go (right):

https://codereview.appspot.com/109010043/diff/40001/vp8l/decode.go#newcode199
vp8l/decode.go:199: return errors.New("vp8l: invalid code lengths")
On 2014/06/16 20:07:37, r wrote:
> another error you could reuse

Done.

https://codereview.appspot.com/109010043/diff/40001/vp8l/huffman.go
File vp8l/huffman.go (right):

https://codereview.appspot.com/109010043/diff/40001/vp8l/huffman.go#newcode91
vp8l/huffman.go:91: return errors.New("vp8l: invalid Huffman tree")
On 2014/06/16 20:07:37, r wrote:
> define this error once

Done.

https://codereview.appspot.com/109010043/diff/40001/vp8l/huffman.go#newcode160
vp8l/huffman.go:160: return errors.New("vp8l: invalid Huffman tree")
On 2014/06/16 20:07:37, r wrote:
> see, it's everywhere

Done.

https://codereview.appspot.com/109010043/diff/40001/vp8l/transform.go
File vp8l/transform.go (right):

https://codereview.appspot.com/109010043/diff/40001/vp8l/transform.go#newcode16
vp8l/transform.go:16: transformTypePredictor     = 0
On 2014/06/16 20:07:37, r wrote:
> you could use iota here

I prefer explicit constants, especially if the values are baked into the wire
format.

[nigeltao, 2014-06-17 11:52:24]

*** Submitted as
https://code.google.com/p/go/source/detail?r=490b1ad139b3&repo=image ***

go.image/vp8l: new package.

The blue-purple-pink image comes from
http://blog.golang.org/gophercon

The tux and yellow_rose images come from
https://developers.google.com/speed/webp/gallery2 and according to
that page, those images are in the public domain.

The gopher-doc images are http://golang.org/doc/gopher/doc.png
after quantizing its palette to 2/4/16/256 colors.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/109010043