code review 109000049: image: add AtRGBA, AtGray16, etc.

image: add RGBAAt, Gray16At, etc.

Fixes issue 7694.

[chai2010, 2014-06-18 01:54:46]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[nigeltao, 2014-06-18 03:15:16]

LGTM but I'll wait a day or two to give r and rsc a chance to give their
thoughts.

[rsc, 2014-06-18 04:54:03]

lgtm but wait for r

[r, 2014-06-18 05:07:34]

https://codereview.appspot.com/109000049/diff/40001/src/pkg/image/image.go
File src/pkg/image/image.go (right):

https://codereview.appspot.com/109000049/diff/40001/src/pkg/image/image.go#ne...
src/pkg/image/image.go:78: func (p *RGBA) AtRGBA(x, y int) color.RGBA {
RGBAAt is a better name, although it looks funny. we're not at an RGBA, this is
the RGBA at that point.

[chai2010, 2014-06-18 05:57:13]

PTAL

https://codereview.appspot.com/109000049/diff/40001/src/pkg/image/image.go
File src/pkg/image/image.go (right):

https://codereview.appspot.com/109000049/diff/40001/src/pkg/image/image.go#ne...
src/pkg/image/image.go:78: func (p *RGBA) AtRGBA(x, y int) color.RGBA {
On 2014/06/18 05:07:33, r wrote:
> RGBAAt is a better name, although it looks funny. we're not at an RGBA, this
is
> the RGBA at that point.

Done.

[nigeltao, 2014-06-18 06:17:02]

Heh, I actually prefer AtRGBA over RGBAAt, to be consistent with At is to AtRGBA
as Set is to SetRGBA.

But at this point, we're bikeshedding. RGBAAt is OK, I guess, unless anyone
strongly disagrees...

[chai2010, 2014-06-18 06:50:16]

On 2014/06/18 06:17:02, nigeltao wrote:
> Heh, I actually prefer AtRGBA over RGBAAt, to be consistent with At is to
AtRGBA
> as Set is to SetRGBA.
> 
> But at this point, we're bikeshedding. RGBAAt is OK, I guess, unless anyone
> strongly disagrees...

For Paletted, Set is to SetColorIndex, but At is to ColorIndexAt.

[nigeltao, 2014-06-19 00:11:11]

LGTM.

[r, 2014-06-19 00:14:58]

LGTM. leaving for nigeltao to commit

[nigeltao, 2014-06-19 00:15:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=402a48892b57 ***

image: add RGBAAt, Gray16At, etc.

Fixes issue 7694.

LGTM=nigeltao, rsc, r
R=golang-codereviews, nigeltao, rsc, r
CC=golang-codereviews
https://codereview.appspot.com/109000049

Committer: Nigel Tao <nigeltao@golang.org>

[gobot, 2014-06-19 04:14:32]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/4e49964f4e32952874739464b77c3d1924630f37