Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(464)

Issue 108860043: code review 108860043: cmd/gc: fix escape analysis for &x inside switch x := v... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsc
Modified:
9 years, 9 months ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

cmd/gc: fix escape analysis for &x inside switch x := v.(type) The analysis for &x was using the loop depth on x set during x's declaration. A type switch creates a list of implicit declarations that were not getting initialized with loop depths. Fixes issue 8176.

Patch Set 1 #

Patch Set 2 : diff -r 00224712f89e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 00224712f89e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6146799f32ed https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M src/cmd/gc/esc.c View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download
M test/escape2.go View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 9 months ago (2014-06-10 21:02:32 UTC) #1
iant
LGTM
9 years, 9 months ago (2014-06-10 21:11:17 UTC) #2
rsc
9 years, 9 months ago (2014-06-11 15:48:17 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f153208c0a0e ***

cmd/gc: fix escape analysis for &x inside switch x := v.(type)

The analysis for &x was using the loop depth on x set
during x's declaration. A type switch creates a list of
implicit declarations that were not getting initialized
with loop depths.

Fixes issue 8176.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/108860043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b