Issue 108840043: code review 108840043: runtime: add test for issue 8047.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108840043: code review 108840043: runtime: add test for issue 8047. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by khr

Modified:
9 years, 10 months ago

Reviewers:
rsc, dvyukov

CC:
dvyukov, rsc, golang-codereviews

Visibility:
Public.

Description

runtime: add test for issue 8047. Make sure stack copier doesn't barf on a nil defer. Bug was fixed in https://codereview.appspot.com/101800043 This change just adds a test. Fixes issue 8047

Patch Set 1 #

Patch Set 2 : diff -r 00224712f89e https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 00224712f89e https://khr%40golang.org@code.google.com/p/go/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	A	test/fixedbugs/issue8047.go	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

khr

Hello dvyukov@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

9 years, 10 months ago (2014-06-09 22:59:31 UTC) #1

rsc

9 years, 10 months ago (2014-06-12 00:34:50 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=3a2306461574 ***

runtime: add test for issue 8047.

Make sure stack copier doesn't barf on a nil defer.
Bug was fixed in https://codereview.appspot.com/101800043
This change just adds a test.

Fixes issue 8047

LGTM=dvyukov, rsc
R=dvyukov, rsc
CC=golang-codereviews
https://codereview.appspot.com/108840043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages