code review 10868045: go.talks: refactor Playground JavaScript API

go.talks: refactor Playground JavaScript API

These changes will be propagated to the go-tour, go-playground, and go core.

[adg, 2013-07-04 03:06:54]

Hello dsymonds (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[dsymonds, 2013-07-04 03:20:42]

LGTM

as long as you've tested this in all those contexts.

https://codereview.appspot.com/10868045/diff/12001/present/js/playground.js
File present/js/playground.js (right):

https://codereview.appspot.com/10868045/diff/12001/present/js/playground.js#n...
present/js/playground.js:28: Body: 'string', // content of write or end status
message
delete trailing comma

https://codereview.appspot.com/10868045/diff/12001/present/js/playground.js#n...
present/js/playground.js:35: // Body string ("killed", for example).
mention if the 'end' kind with a body signals a failure.

https://codereview.appspot.com/10868045/diff/12001/present/play.go
File present/play.go (right):

https://codereview.appspot.com/10868045/diff/12001/present/play.go#newcode20
present/play.go:20: func playScript(root string, transport string) {
(root, transport string)

extend the func comment to say what some valid transports are.

https://codereview.appspot.com/10868045/diff/12001/present/play.go#newcode30
present/play.go:30: fmt.Fprintf(&buf, "\ninitPlayground(new %v());\n",
transport)
paranoid me says you should JS-escape transport here, because one day it might
come from user input.

[adg, 2013-07-04 03:28:06]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b3cad5151b4a&repo=talks ***

go.talks: refactor Playground JavaScript API

These changes will be propagated to the go-tour, go-playground, and go core.

R=dsymonds
CC=golang-dev
https://codereview.appspot.com/10868045

https://codereview.appspot.com/10868045/diff/12001/present/js/playground.js
File present/js/playground.js (right):

https://codereview.appspot.com/10868045/diff/12001/present/js/playground.js#n...
present/js/playground.js:28: Body: 'string', // content of write or end status
message
On 2013/07/04 03:20:42, dsymonds wrote:
> delete trailing comma

Done.

https://codereview.appspot.com/10868045/diff/12001/present/js/playground.js#n...
present/js/playground.js:35: // Body string ("killed", for example).
On 2013/07/04 03:20:42, dsymonds wrote:
> mention if the 'end' kind with a body signals a failure.

Done.

https://codereview.appspot.com/10868045/diff/12001/present/play.go
File present/play.go (right):

https://codereview.appspot.com/10868045/diff/12001/present/play.go#newcode20
present/play.go:20: func playScript(root string, transport string) {
On 2013/07/04 03:20:42, dsymonds wrote:
> (root, transport string)
> 
> extend the func comment to say what some valid transports are.

Done.

https://codereview.appspot.com/10868045/diff/12001/present/play.go#newcode30
present/play.go:30: fmt.Fprintf(&buf, "\ninitPlayground(new %v());\n",
transport)
On 2013/07/04 03:20:42, dsymonds wrote:
> paranoid me says you should JS-escape transport here, because one day it might
> come from user input.

It really won't. Ever. I promise.