Issue 10862043: code review 10862043: go-tour: panic on failed png encode in tour/pic.ShowImage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10862043: code review 10862043: go-tour: panic on failed png encode in tour/pic.ShowImage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adg

Modified:
10 years, 10 months ago

Reviewers:
minux1

CC:
golang-dev, minux1

Visibility:
Public.

Description

go-tour: panic on failed png encode in tour/pic.ShowImage Fixes issue 59.

Patch Set 1 #

Patch Set 2 : diff -r b32ba9b8d870 https://code.google.com/p/go-tour #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	pic/pic.go	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 10 months ago (2013-07-02 06:29:34 UTC) #1

adg

10 years, 10 months ago (2013-07-02 22:30:24 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=7d6e524a6ade
***

go-tour: panic on failed png encode in tour/pic.ShowImage

Fixes issue 59.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/10862043

Expand All Messages | Collapse All Messages