Issue 108570043: code review 108570043: liblink: fix warnings on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108570043: code review 108570043: liblink: fix warnings on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by 0intro

Modified:
10 years, 8 months ago

Reviewers:
minux

CC:
minux, golang-codereviews

Visibility:
Public.

Description

liblink: fix warnings on Plan 9 warning: /usr/go/src/liblink/asm5.c:720 set and not used: m warning: /usr/go/src/liblink/asm5.c:807 set and not used: c

Patch Set 2 : diff -r 36cc211b26b4 https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 36cc211b26b4 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	src/liblink/asm5.c	View	1 2	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello minux (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2014-07-11 20:12:10 UTC) #1

minux

LGTM. https://codereview.appspot.com/108570043/diff/40001/src/liblink/asm5.c File src/liblink/asm5.c (right): https://codereview.appspot.com/108570043/diff/40001/src/liblink/asm5.c#newcode803 src/liblink/asm5.c:803: m = o->size; you may as well remove ...

10 years, 8 months ago (2014-07-11 20:19:50 UTC) #2

0intro

https://codereview.appspot.com/108570043/diff/40001/src/liblink/asm5.c File src/liblink/asm5.c (right): https://codereview.appspot.com/108570043/diff/40001/src/liblink/asm5.c#newcode803 src/liblink/asm5.c:803: m = o->size; On 2014/07/11 20:19:50, minux wrote: > ...

10 years, 8 months ago (2014-07-11 20:24:20 UTC) #3

0intro

10 years, 8 months ago (2014-07-11 20:24:51 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=59c67dc02832 ***

liblink: fix warnings on Plan 9

warning: /usr/go/src/liblink/asm5.c:720 set and not used: m
warning: /usr/go/src/liblink/asm5.c:807 set and not used: c

LGTM=minux
R=minux
CC=golang-codereviews
https://codereview.appspot.com/108570043

Expand All Messages | Collapse All Messages