code review 108260043: collate/build: fix go vet warning about Fprintln

collate/build: fix go vet warning about Fprintln

  builder.go:505: Fprintln call ends with newline

[patrick2, 2014-06-29 08:28:35]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.text

[josharian, 2014-06-30 16:24:15]

Thanks for fixing these. A nitpick:

https://codereview.appspot.com/108260043/diff/10002/collate/build/builder.go
File collate/build/builder.go (right):

https://codereview.appspot.com/108260043/diff/10002/collate/build/builder.go#...
collate/build/builder.go:505: p(fmt.Fprintf(w, "\"\n\n"))
Since there are no formatting directives, may as well use Fprint instead of
Fprintf. I think that this applies to your other recent CLs as well.

[mpvl, 2014-06-30 17:45:36]

https://codereview.appspot.com/108260043/diff/10002/collate/build/builder.go
File collate/build/builder.go (right):

https://codereview.appspot.com/108260043/diff/10002/collate/build/builder.go#...
collate/build/builder.go:505: p(fmt.Fprintf(w, "\"\n\n"))
On 2014/06/30 16:24:15, josharian wrote:
> Since there are no formatting directives, may as well use Fprint instead of
> Fprintf. I think that this applies to your other recent CLs as well.
Yes, Fprint would be better in this case.

[patrick2, 2014-06-30 18:22:29]

Hello golang-codereviews@googlegroups.com, josharian@gmail.com, mpvl@golang.org,

Please take another look.

[mpvl, 2014-06-30 20:56:22]

LGTM

[josharian, 2014-07-01 01:14:43]

LGTM

[josharian, 2014-07-01 01:14:54]

*** Submitted as
https://code.google.com/p/go/source/detail?r=c59e4f2f9382&repo=text ***

collate/build: fix go vet warning about Fprintln

  builder.go:505: Fprintln call ends with newline

LGTM=mpvl, josharian
R=golang-codereviews, josharian, mpvl
CC=golang-codereviews
https://codereview.appspot.com/108260043

Committer: Josh Bleecher Snyder <josharian@gmail.com>