Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1342)

Issue 108120045: code review 108120045: time: only allow one occurrence of a unit in ParseDuration.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by unrolled
Modified:
9 years, 3 months ago
Reviewers:
rsc
CC:
golang-codereviews, dfc, ruiu, rsc
Visibility:
Public.

Description

time: only allow one occurrence of a unit in ParseDuration. Fixes issue 7615.

Patch Set 1 #

Patch Set 2 : diff -r f0aac550f96e https://code.google.com/p/go #

Patch Set 3 : diff -r f0aac550f96e https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/pkg/time/format.go View 1 2 chunks +5 lines, -0 lines 1 comment Download
M src/pkg/time/time_test.go View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
unrolled
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-06-22 13:36:01 UTC) #1
dfc
https://codereview.appspot.com/108120045/diff/40001/src/pkg/time/format.go File src/pkg/time/format.go (right): https://codereview.appspot.com/108120045/diff/40001/src/pkg/time/format.go#newcode1163 src/pkg/time/format.go:1163: seen := map[string]bool{} A map is a heavy weight ...
9 years, 9 months ago (2014-06-22 23:40:24 UTC) #2
ruiu
One can argue that this change would break compatibility. I'd think we need to discuss ...
9 years, 9 months ago (2014-06-22 23:48:00 UTC) #3
unrolled
On 2014/06/22 23:48:00, ruiu wrote: > One can argue that this change would break compatibility. ...
9 years, 9 months ago (2014-06-23 15:19:00 UTC) #4
rsc
not lgtm just leave it alone
9 years, 3 months ago (2014-12-04 16:40:04 UTC) #5
gobot
9 years, 3 months ago (2014-12-19 05:10:06 UTC) #6
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/108120045 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b