Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 107970043: code review 107970043: runtime: do not trace past jmpdefer during pprof traceb... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsc
Modified:
9 years, 9 months ago
Reviewers:
minux, iant
CC:
golang-codereviews, minux, iant, r
Visibility:
Public.

Description

runtime: do not trace past jmpdefer during pprof traceback on arm jmpdefer modifies PC, SP, and LR, and not atomically, so walking past jmpdefer will often end up in a state where the three are not a consistent execution snapshot. This was causing warning messages a few frames later when the traceback realized it was confused, but given the right memory it could easily crash instead. Update issue 8153

Patch Set 1 #

Patch Set 2 : diff -r bef07f7786d6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bef07f7786d6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c2832405e9b9 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/pkg/runtime/asm_arm.s View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
9 years, 9 months ago (2014-06-12 19:00:31 UTC) #1
minux
This is the atomic update version of runtime.jmpdefer, I will send a CL for 1.4. ...
9 years, 9 months ago (2014-06-12 19:40:59 UTC) #2
iant
LGTM
9 years, 9 months ago (2014-06-12 20:01:17 UTC) #3
rsc
9 years, 9 months ago (2014-06-12 20:34:52 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=b336da131a84 ***

runtime: do not trace past jmpdefer during pprof traceback on arm

jmpdefer modifies PC, SP, and LR, and not atomically,
so walking past jmpdefer will often end up in a state
where the three are not a consistent execution snapshot.
This was causing warning messages a few frames later
when the traceback realized it was confused, but given
the right memory it could easily crash instead.

Update issue 8153

LGTM=minux, iant
R=golang-codereviews, minux, iant
CC=golang-codereviews, r
https://codereview.appspot.com/107970043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b