Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1342)

Issue 10783043: code review 10783043: cmd/gc: add go:norace annotation to disable race instru... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by dvyukov
Modified:
10 years, 9 months ago
Reviewers:
r, rsc, golang-dev
Visibility:
Public.

Description

cmd/gc: add go:norace annotation to disable race instrumentation The annotation can be used to: 1. not instrument some sensitive functions (e.g. that call fork()) 2. temporary ignore known data races 3. gain additional performance by not instrumenting very hot functions Note that there is another similar potentially useful annotation -- that does not instrument memory accesses, but instrument func enter/exit. It would allow to achieve (2) and (3) while preserving correct stack traces in reports. If/when we add it, the plan is to name it along the lines of go:norace-something (e.g. go:norace-access). Update issue 4840.

Patch Set 1 #

Patch Set 2 : diff -r 166d946fa77f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 166d946fa77f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r c224c549a3c7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r c224c549a3c7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r c224c549a3c7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r c224c549a3c7 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -134 lines) Patch
M src/cmd/gc/doc.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.y View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/gc/lex.c View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/cmd/gc/racewalk.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/y.tab.c View 1 46 chunks +134 lines, -132 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 9 months ago (2013-06-29 11:56:42 UTC) #1
dvyukov
On 2013/06/29 11:56:42, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
10 years, 9 months ago (2013-06-29 11:59:47 UTC) #2
dvyukov
Usage of this new attribute is in https://codereview.appspot.com/10782044
10 years, 9 months ago (2013-06-29 12:00:48 UTC) #3
rsc
+r for new annotation I think "norace" is not a great prefix: it locks you ...
10 years, 9 months ago (2013-07-01 21:33:52 UTC) #4
r
I agree with the dislike of "norace". Negative true is just confusing.
10 years, 9 months ago (2013-07-01 23:49:11 UTC) #5
rsc
NOT LGTM, at least not yet. This is a big thing to commit to, and ...
10 years, 9 months ago (2013-07-11 17:50:58 UTC) #6
dvyukov
10 years, 9 months ago (2013-07-16 09:46:14 UTC) #7
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b