Issue 1077041: code review 1077041: nacl: another attempt at fixing build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1077041: code review 1077041: nacl: another attempt at fixing build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

nacl: another attempt at fixing build

Patch Set 1 #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/all-nacl.bash	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-05-03 18:12:53 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=b076d1c7eb80 *** nacl: another attempt at fixing build TBR=r CC=golang-dev http://codereview.appspot.com/1077041

14 years, 11 months ago (2010-05-03 18:12:57 UTC) #2

14 years, 11 months ago (2010-05-03 18:46:13 UTC) #3

LGTM

On May 3, 2010, at 11:12 AM, rsc@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> nacl: another attempt at fixing build
> 
> Please review this at http://codereview.appspot.com/1077041/show
> 
> Affected files:
>  M src/all-nacl.bash
> 
> 
> Index: src/all-nacl.bash
> ===================================================================
> --- a/src/all-nacl.bash
> +++ b/src/all-nacl.bash
> @@ -7,7 +7,7 @@
> 
> export GOARCH=386
> export GOOS=nacl
> -export GORUN="$GOROOT/misc/nacl/naclrun"
> +export GORUN=${GORUN:-$GOROOT/misc/nacl/naclrun}
> 
> set -e
> bash make.bash
> 
>

Expand All Messages | Collapse All Messages