Issue 10757044: code review 10757044: runtime: correctly handle signals received on foreign t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10757044: code review 10757044: runtime: correctly handle signals received on foreign t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by minux1

Modified:
10 years, 9 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: correctly handle signals received on foreign threads Fixes issue 3250.

Patch Set 1 #

Patch Set 2 : diff -r 06606915c043 https://code.google.com/p/go #

Patch Set 3 : diff -r 06606915c043 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 79764384421c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3a89d3776b93 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 3a89d3776b93 https://code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -159 lines)			Patch
M	misc/cgo/test/cgo_test.go	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	misc/cgo/test/issue3250.go	View	1 2	1 chunk	+94 lines, -0 lines	0 comments	Download
A	misc/cgo/test/issue3250w.go	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_darwin.c	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/pkg/runtime/os_freebsd.c	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/pkg/runtime/os_linux.c	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/pkg/runtime/os_netbsd.c	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/pkg/runtime/os_openbsd.c	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/pkg/runtime/os_plan9.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/sigqueue.goc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/sys_darwin_386.s	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/sys_darwin_amd64.s	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/sys_freebsd_386.s	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/sys_freebsd_amd64.s	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/sys_freebsd_arm.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_linux_386.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_linux_amd64.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_linux_arm.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_netbsd_386.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_netbsd_amd64.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_netbsd_arm.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_openbsd_386.s	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/sys_openbsd_amd64.s	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_plan9_386.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/sys_plan9_amd64.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 9 months ago (2013-07-11 20:39:27 UTC) #2

minux1

10 years, 9 months ago (2013-07-11 20:39:57 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9c7e1d1fe912 ***

runtime: correctly handle signals received on foreign threads
Fixes issue 3250.

R=rsc
CC=golang-dev
https://codereview.appspot.com/10757044

Expand All Messages | Collapse All Messages