Issue 10729043: code review 10729043: go-tour: trim spaces around source code before displaying

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10729043: code review 10729043: go-tour: trim spaces around source code before displaying (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adg

Modified:
10 years, 10 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

go-tour: trim spaces around source code before displaying Changes to the way code is generated add some space around the code snippets, which can be quite ugly. This fixes that issue.

Patch Set 1 #

Patch Set 2 : diff -r 63620f922bb2 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 63620f922bb2 https://code.google.com/p/go-tour #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	js/tour.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 10 months ago (2013-06-28 02:33:59 UTC) #1

adg

10 years, 10 months ago (2013-06-29 05:08:16 UTC) #2

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=e06d779edc4d
***

go-tour: trim spaces around source code before displaying

Changes to the way code is generated add some space around the
code snippets, which can be quite ugly. This fixes that issue.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/10729043

Expand All Messages | Collapse All Messages