Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(744)

Issue 106990043: code review 106990043: fmt: don't put 0x on every byte of a compact hex-encode... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by r
Modified:
9 years, 9 months ago
Reviewers:
gri, bradfitz
CC:
golang-codereviews, bradfitz, gri
Visibility:
Public.

Description

fmt: don't put 0x on every byte of a compact hex-encoded string Printf("%x", "abc") was "0x610x620x63"; is now "0x616263", which is surely better. Printf("% #x", "abc") is still "0x61 0x62 0x63". Fixes issue 8080.

Patch Set 1 #

Patch Set 2 : diff -r 7d2e78c502ab https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/pkg/fmt/fmt_test.go View 2 chunks +7 lines, -3 lines 0 comments Download
M src/pkg/fmt/format.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-06-11 21:37:17 UTC) #1
r
ping
9 years, 9 months ago (2014-06-16 17:40:36 UTC) #2
r
It's LGTMed but the dashboard doesn't know. That bug again. On Mon, Jun 16, 2014 ...
9 years, 9 months ago (2014-06-16 17:42:25 UTC) #3
bradfitz
LGTM They've rolled back the rietveld bug. On Jun 16, 2014 10:42 AM, "Rob Pike" ...
9 years, 9 months ago (2014-06-16 17:43:05 UTC) #4
gri
LGTM
9 years, 9 months ago (2014-06-16 17:43:56 UTC) #5
r
9 years, 9 months ago (2014-06-16 17:44:15 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=290a2cbe3bf5 ***

fmt: don't put 0x on every byte of a compact hex-encoded string
Printf("%x", "abc") was "0x610x620x63"; is now "0x616263", which
is surely better.
Printf("% #x", "abc") is still "0x61 0x62 0x63".

Fixes issue 8080.

LGTM=bradfitz, gri
R=golang-codereviews, bradfitz, gri
CC=golang-codereviews
https://codereview.appspot.com/106990043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b