Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2909)

Issue 10669043: code review 10669043: misc/notepadplus: change dot and underscore character k... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by chai2010
Modified:
10 years, 10 months ago
Reviewers:
dave, golang-dev
Visibility:
Public.

Description

misc/notepadplus: change dot and underscore character keyword type "_" is a predeclared identifier, not a operator. "." is a selector, x.f should be one identifier highlight. so the fix is to change it. Fixes issue 5798.

Patch Set 1 #

Patch Set 2 : diff -r d3f99f091748 http://code.google.com/p/go #

Patch Set 3 : diff -r d3f99f091748 http://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M misc/notepadplus/userDefineLang.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
chai2010
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go
10 years, 10 months ago (2013-06-27 06:54:22 UTC) #1
chai2010
On 2013/06/27 06:54:22, chai2010 wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
10 years, 10 months ago (2013-06-28 02:42:21 UTC) #2
dave_cheney.net
On 2013/06/28 02:42:21, chai2010 wrote: > On 2013/06/27 06:54:22, chai2010 wrote: > > Hello mailto:golang-dev@googlegroups.com, ...
10 years, 10 months ago (2013-06-28 02:45:58 UTC) #3
chai2010
10 years, 10 months ago (2013-06-28 02:47:10 UTC) #4
Message was sent while issue was closed.
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b