Issue 10624044: code review 10624044: crypto/md5: provide a top-level Sum function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10624044: code review 10624044: crypto/md5: provide a top-level Sum function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by r

Modified:
10 years, 9 months ago

Reviewers:
agl1

CC:
golang-dev, agl1

Visibility:
Public.

Description

crypto/md5: provide a top-level Sum function Makes it easy to ask the simple question, what is the hash of this data? Also mark block as non-escaping.

Patch Set 1 #

Patch Set 2 : diff -r 4724e59b3b85 https://code.google.com/p/go #

Patch Set 3 : diff -r 4724e59b3b85 https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
M	src/pkg/crypto/md5/md5.go	View	1	2 chunks	+13 lines, -1 line	0 comments	Download
M	src/pkg/crypto/md5/md5_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/md5/md5block_decl.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-06-26 18:11:13 UTC) #1

10 years, 9 months ago (2013-06-26 18:29:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d4e29abfb2e0 ***

crypto/md5: provide a top-level Sum function
Makes it easy to ask the simple question, what is the hash of this data?
Also mark block as non-escaping.

R=golang-dev, agl
CC=golang-dev
https://codereview.appspot.com/10624044

Expand All Messages | Collapse All Messages