Issue 105750045: code review 105750045: go.image/tiff: fix (TIFF-specific) LZW decompression.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105750045: code review 105750045: go.image/tiff: fix (TIFF-specific) LZW decompression. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by nigeltao

Modified:
9 years, 11 months ago

Reviewers:
bsiegert, djd

CC:
djd, bsiegert, golang-codereviews

Visibility:
Public.

Description

go.image/tiff: fix (TIFF-specific) LZW decompression. The blue-purple-pink.lzwcompressed.tiff image was created by "bmp2tiff -c lzw".

Patch Set 2 : diff -r b45f3856d47b https://code.google.com/p/go.image #

Patch Set 3 : diff -r b45f3856d47b https://code.google.com/p/go.image #

Patch Set 4 : diff -r b45f3856d47b https://code.google.com/p/go.image #

Patch Set 5 : diff -r b45f3856d47b https://code.google.com/p/go.image #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -8 lines)			Patch
A	testdata/blue-purple-pink.png	View	1	Binary file		0 comments	Download
A	testdata/blue-purple-pink.lzwcompressed.tiff	View	1	Binary file		0 comments	Download
M	tiff/lzw/reader.go	View	1 2 3	3 chunks	+26 lines, -7 lines	0 comments	Download
M	tiff/reader.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tiff/reader_test.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello djd@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 11 months ago (2014-06-02 04:19:32 UTC) #1

nigeltao

*** Submitted as https://code.google.com/p/go/source/detail?r=0af0d404b49c&repo=image *** go.image/tiff: fix (TIFF-specific) LZW decompression. The blue-purple-pink.lzwcompressed.tiff image was created ...

9 years, 11 months ago (2014-06-02 04:52:06 UTC) #4

bsiegert

9 years, 11 months ago (2014-06-02 19:59:52 UTC) #5

LGTM

Thanks so much for finding this. I never found the issue.
On Mon Jun 02 2014 at 06:52:06, <nigeltao@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=0af0d404b49c&repo=image ***
>
> go.image/tiff: fix (TIFF-specific) LZW decompression.
>
> The blue-purple-pink.lzwcompressed.tiff image was created by
> "bmp2tiff -c lzw".
>
> LGTM=djd
> R=djd
> CC=bsiegert, golang-codereviews
> https://codereview.appspot.com/105750045
>
>
> https://codereview.appspot.com/105750045/
>

Expand All Messages | Collapse All Messages