Issue 105580043: code review 105580043: go.crypto/ssh/terminal: better handling of window resizing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105580043: code review 105580043: go.crypto/ssh/terminal: better handling of window resizing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by agl1

Modified:
9 years, 8 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Description

go.crypto/ssh/terminal: better handling of window resizing. There doesn't appear to be perfect behaviour for line editing code in the face of terminal resizing. But this change works pretty well on xterm and gnome-terminal and certainly a lot better than it used to.

Patch Set 1 #

Patch Set 2 : diff -r 8a278ade38cb https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 8a278ade38cb https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 8a278ade38cb https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 8a278ade38cb https://code.google.com/p/go.crypto/ #

Total comments: 4

Patch Set 6 : diff -r aa2644fe4aa5 https://code.google.com/p/go.crypto/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -27 lines)			Patch
	M	ssh/terminal/terminal.go	View		13 chunks	+116 lines, -27 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

9 years, 9 months ago (2014-07-04 22:43:13 UTC) #1

bradfitz

LGTM I guess I've never used this package and this isn't an area I know ...

9 years, 9 months ago (2014-07-14 21:14:26 UTC) #3

agl1

https://codereview.appspot.com/105580043/diff/70001/ssh/terminal/terminal.go File ssh/terminal/terminal.go (right): https://codereview.appspot.com/105580043/diff/70001/ssh/terminal/terminal.go#newcode769 ssh/terminal/terminal.go:769: return On 2014/07/14 21:14:26, bradfitz wrote: > should SetSize ...

9 years, 8 months ago (2014-08-01 18:18:44 UTC) #4

agl1

9 years, 8 months ago (2014-08-01 18:23:17 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=34cc409bf31e&repo=crypto ***

go.crypto/ssh/terminal: better handling of window resizing.

There doesn't appear to be perfect behaviour for line editing
code in the face of terminal resizing. But this change works
pretty well on xterm and gnome-terminal and certainly a lot
better than it used to.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/105580043

Expand All Messages | Collapse All Messages