Issue 105500043: code review 105500043: codereview: revive the tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105500043: code review 105500043: codereview: revive the tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by minux

Modified:
10 years, 8 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

codereview: revive the tests.

Patch Set 1 #

Patch Set 2 : diff -r 1fcd603852b0 https://code.google.com/p/go #

Patch Set 3 : diff -r 1fcd603852b0 https://code.google.com/p/go #

Patch Set 4 : diff -r 5f017e1d0129 https://code.google.com/p/go #

Patch Set 5 : diff -r 4db0802fd3fd https://code.google.com/p/go #

Patch Set 6 : diff -r ac84ecc92810 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	lib/codereview/codereview.py	View		8 chunks	+21 lines, -5 lines	0 comments	Download
	M	lib/codereview/test.sh	View		7 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2014-07-01 22:22:38 UTC) #1

minux

10 years, 8 months ago (2014-07-19 01:00:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d0e5709db0ea ***

codereview: revive the tests.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/105500043

Expand All Messages | Collapse All Messages