Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(223)

Issue 105310043: code review 105310043: [release-branch.go1.3] fmt: fix signs when zero padding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsc
Modified:
9 years, 9 months ago
Reviewers:
r, minux
CC:
golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] fmt: fix signs when zero padding. ««« CL 103480043 / 777dd5a434db fmt: fix signs when zero padding. Bug was introduced recently. Add more tests, fix the bugs. Suppress + sign when not required in zero padding. Do not zero pad infinities. All old tests still pass. This time for sure! Fixes issue 8217. LGTM=rsc R=golang-codereviews, dan.kortschak, rsc CC=golang-codereviews https://codereview.appspot.com/103480043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 4db9bc6775ea https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -43 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 2 chunks +113 lines, -2 lines 0 comments Download
M src/pkg/fmt/format.go View 1 2 chunks +38 lines, -41 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 9 months ago (2014-06-18 04:58:36 UTC) #1
r
LGTM
9 years, 9 months ago (2014-06-18 05:05:39 UTC) #2
minux
FYI, adg has also sent CL 110040043, and r has LGTMed that one.
9 years, 9 months ago (2014-06-18 05:06:07 UTC) #3
rsc
9 years, 9 months ago (2014-06-18 05:07:58 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b