Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 105140044: code review 105140044: runtime: fix defer of nil func (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsc
Modified:
9 years, 9 months ago
Reviewers:
r, gobot, iant
CC:
golang-codereviews, r, iant, dvyukov, khr
Visibility:
Public.

Description

runtime: fix defer of nil func Fixes issue 8047.

Patch Set 1 #

Patch Set 2 : diff -r bef07f7786d6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bef07f7786d6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r bef07f7786d6 https://code.google.com/p/go/ #

Patch Set 5 : diff -r bef07f7786d6 https://code.google.com/p/go/ #

Patch Set 6 : diff -r d9c3411f6146 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/pkg/runtime/stack.c View 1 1 chunk +6 lines, -1 line 0 comments Download
A test/fixedbugs/issue8047b.go View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...
9 years, 9 months ago (2014-06-12 18:54:59 UTC) #1
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov@google.com, golang-codereviews@googlegroups.com, iant@golang.org, khr@golang.org, r@golang.org), Please take another look.
9 years, 9 months ago (2014-06-12 18:56:27 UTC) #2
r
LGTM
9 years, 9 months ago (2014-06-12 19:16:32 UTC) #3
iant
LGTM
9 years, 9 months ago (2014-06-12 19:58:10 UTC) #4
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=c2832405e9b9 *** runtime: fix defer of nil func Fixes issue 8047. LGTM=r, ...
9 years, 9 months ago (2014-06-12 20:34:34 UTC) #5
gobot
9 years, 9 months ago (2014-06-12 21:36:14 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/eb246af1c345b7db8c5b92ee09ac938f3fdfd016
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b