Issue 105140043: code review 105140043: time: avoid broken fix for buggy TestOverflowRuntimeTimer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105140043: code review 105140043: time: avoid broken fix for buggy TestOverflowRuntimeTimer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by r

Modified:
9 years, 10 months ago

Reviewers:
rsc

CC:
rsc, josharian, golang-codereviews

Visibility:
Public.

Description

time: avoid broken fix for buggy TestOverflowRuntimeTimer The test requires that timerproc runs, but busy loops and starves the scheduler so that, with high probability, timerproc doesn't run. Avoid the issue by expecting the test to succeed; if not, a major outside timeout will kill it and let us know. As you can see from the diffs, there have been several attempts to fix this with chicanery, but none has worked. Don't bother trying any more. Fixes issue 8136.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 052730f52c17 https://code.google.com/p/go #

Patch Set 3 : diff -r a507dd224581 https://code.google.com/p/go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -45 lines)			Patch
	M	src/pkg/time/internal_test.go	View	1	4 chunks	+9 lines, -42 lines	0 comments	Download
	M	src/pkg/time/sleep_test.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 10 months ago (2014-06-12 18:30:46 UTC) #1

josharian

https://codereview.appspot.com/105140043/diff/1/src/pkg/time/internal_test.go File src/pkg/time/internal_test.go (right): https://codereview.appspot.com/105140043/diff/1/src/pkg/time/internal_test.go#newcode22 src/pkg/time/internal_test.go:22: func CheckRuntimeTimerOverflow() error { s/error// and remove the return ...

9 years, 10 months ago (2014-06-12 18:40:51 UTC) #3

9 years, 10 months ago (2014-06-12 18:44:29 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=d9c3411f6146 ***

time: avoid broken fix for buggy TestOverflowRuntimeTimer
The test requires that timerproc runs, but busy loops and starves
the scheduler so that, with high probability, timerproc doesn't run.
Avoid the issue by expecting the test to succeed; if not, a major
outside timeout will kill it and let us know.

As you can see from the diffs, there have been several attempts to
fix this with chicanery, but none has worked. Don't bother trying
any more.

Fixes issue 8136.

LGTM=rsc
R=rsc, josharian
CC=golang-codereviews
https://codereview.appspot.com/105140043

Expand All Messages | Collapse All Messages