Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(191)

Issue 105110044: code review 105110044: net: improve behavior of native Go DNS queries (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by axaxs
Modified:
9 years, 7 months ago
Visibility:
Public.

Description

net: improve behavior of native Go DNS queries Speed improvements via code cleanup, and changes to make go dns behave more like glibc resolver. See https://groups.google.com/forum/#!topic/golang-dev/lV-0aHqxVeo Fixes issue 6579. Benchmark results on linux/amd64 benchmark old ns/op new ns/op delta BenchmarkGoLookupIP 61588062 30786782 -50.01% BenchmarkGoLookupIPNoSuchHost 123138626 31487501 -74.43% BenchmarkGoLookupIPWithBrokenNameServer 20063137067 5031143479 -74.92% benchmark old allocs new allocs delta BenchmarkGoLookupIP 105 108 2.86% BenchmarkGoLookupIPNoSuchHost 200 102 -49.00% BenchmarkGoLookupIPWithBrokenNameServer 172 162 -5.81% benchmark old bytes new bytes delta BenchmarkGoLookupIP 12111 11639 -3.90% BenchmarkGoLookupIPNoSuchHost 23251 11820 -49.16% BenchmarkGoLookupIPWithBrokenNameServer 26784 22032 -17.74%

Patch Set 1 #

Patch Set 2 : diff -r 052730f52c17 https://code.google.com/p/go #

Patch Set 3 : diff -r 052730f52c17 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -104 lines) Patch
M src/pkg/net/dnsclient_unix.go View 1 7 chunks +97 lines, -104 lines 0 comments Download
M src/pkg/net/dnsclient_unix_test.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/pkg/net/dnsconfig_unix.go View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
axaxs
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-06-12 03:05:02 UTC) #1
axaxs
On 2014/06/12 03:05:02, axaxs wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
9 years, 9 months ago (2014-06-12 03:06:39 UTC) #2
mikio
hi, before doing this, I'd like to separate dns transport from message interaction to make ...
9 years, 9 months ago (2014-06-12 15:54:45 UTC) #3
axaxs
9 years, 7 months ago (2014-08-09 19:49:02 UTC) #4
On 2014/06/12 15:54:45, mikio wrote:
> hi,
> 
> before doing this, I'd like to separate dns transport from message interaction
> to make things clearer; https://codereview.appspot.com/101220044/

Not sure the proper way to handle this case, but since it's been two months and
the underlying code is radically different, abandoning this one and opening
https://codereview.appspot.com/128820043 based off latest net changes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b