code review 105100046: net: consolidate sockaddrToAddr functions

net: consolidate sockaddrToAddr functions

This CL removes sockaddrToAddr functions from socket creation
operations to avoid the bug like issue 7183.

[mikio, 2014-06-12 16:06:49]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-07-23 19:12:21]

https://codereview.appspot.com/105100046/diff/60001/src/pkg/net/sock_posix.go
File src/pkg/net/sock_posix.go (right):

https://codereview.appspot.com/105100046/diff/60001/src/pkg/net/sock_posix.go...
src/pkg/net/sock_posix.go:100: case (fd.family == syscall.AF_INET || fd.family
== syscall.AF_INET6) && fd.sotype == syscall.SOCK_STREAM:
Maybe add:

  func (fd *netFD) isINET() bool { return (fd.family == syscall.AF_INET ||
fd.family == syscall.AF_INET6) }

Then these get more readable. It will be inlined anyway.

Or do two nested switches, with the outer one on family (INET vs UNIX) and the
inner one on sotype.

https://codereview.appspot.com/105100046/diff/60001/src/pkg/net/sock_posix.go...
src/pkg/net/sock_posix.go:151: fd.setAddr(fd.toAddrFunc()(lsa),
fd.toAddrFunc()(rsa))
maybe just rename this to addrFunc instead of toAddrFunc

[mikio, 2014-08-04 09:16:22]

ptal

https://codereview.appspot.com/105100046/diff/60001/src/pkg/net/sock_posix.go
File src/pkg/net/sock_posix.go (right):

https://codereview.appspot.com/105100046/diff/60001/src/pkg/net/sock_posix.go...
src/pkg/net/sock_posix.go:100: case (fd.family == syscall.AF_INET || fd.family
== syscall.AF_INET6) && fd.sotype == syscall.SOCK_STREAM:
On 2014/07/23 19:12:21, bradfitz wrote:
> Maybe add:
> 
>   func (fd *netFD) isINET() bool { return (fd.family == syscall.AF_INET ||
> fd.family == syscall.AF_INET6) }
> 
> Then these get more readable. It will be inlined anyway.
> 
> Or do two nested switches, with the outer one on family (INET vs UNIX) and the
> inner one on sotype.

Done.

https://codereview.appspot.com/105100046/diff/60001/src/pkg/net/sock_posix.go...
src/pkg/net/sock_posix.go:151: fd.setAddr(fd.toAddrFunc()(lsa),
fd.toAddrFunc()(rsa))
On 2014/07/23 19:12:21, bradfitz wrote:
> maybe just rename this to addrFunc instead of toAddrFunc

Done.

[bradfitz, 2014-08-04 17:25:23]

LGTM

Thanks. This makes things nicer.

[mikio, 2014-08-04 21:10:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=0b42d03c2cd5 ***

net: consolidate sockaddrToAddr functions

This CL removes sockaddrToAddr functions from socket creation
operations to avoid the bug like issue 7183.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/105100046