Issue 10503043: code review 10503043: net/rpc: call client.Close() when test exit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10503043: code review 10503043: net/rpc: call client.Close() when test exit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by chai2010

Modified:
10 years, 10 months ago

Reviewers:
r, golang-dev

Visibility:
Public.

Description

net/rpc: call client.Close() when test exit Fixes issue 5768.

Patch Set 1 #

Patch Set 2 : diff -r af0c031528c3 http://code.google.com/p/go/ #

Patch Set 3 : diff -r af0c031528c3 http://code.google.com/p/go/ #

Patch Set 4 : diff -r af0c031528c3 http://code.google.com/p/go/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/pkg/net/rpc/server_test.go	View	1	8 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

chai2010

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go/

10 years, 10 months ago (2013-06-24 14:18:01 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=e81f9df68307 *** net/rpc: call client.Close() when test exit Fixes issue 5768. R=golang-dev ...

10 years, 10 months ago (2013-06-24 20:18:53 UTC) #2

LGTM

Expand All Messages | Collapse All Messages