Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2467)

Issue 10480044: code review 10480044: misc/notepadplus: add missing single quotation marks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by chai2010
Modified:
10 years, 9 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

misc/notepadplus: use new User Defined Language system (UDL2) Add missing single quotation and backslash marks. Change dot and underscore character keyword type. "_" is a predeclared identifier, not a operator. "." is a selector, x.f should be one identifier highlight. So the fix is to change it. Fixes issue 5775 5788 5798.

Patch Set 1 #

Patch Set 2 : diff -r fc8f4a3920e1 http://code.google.com/p/go #

Patch Set 3 : diff -r fc8f4a3920e1 http://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r fccd815ed3bb http://code.google.com/p/go/ #

Patch Set 5 : diff -r fccd815ed3bb http://code.google.com/p/go #

Patch Set 6 : diff -r fccd815ed3bb http://code.google.com/p/go #

Total comments: 4

Patch Set 7 : diff -r 77be25034f84 http://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -33 lines) Patch
M misc/notepadplus/README View 1 2 3 4 5 6 1 chunk +35 lines, -6 lines 0 comments Download
M misc/notepadplus/userDefineLang.xml View 1 2 3 4 1 chunk +55 lines, -27 lines 0 comments Download

Messages

Total messages: 7
chai2010
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go
10 years, 10 months ago (2013-06-25 02:04:54 UTC) #1
r
https://codereview.appspot.com/10480044/diff/3001/misc/notepadplus/userDefineLang.xml File misc/notepadplus/userDefineLang.xml (right): https://codereview.appspot.com/10480044/diff/3001/misc/notepadplus/userDefineLang.xml#newcode9 misc/notepadplus/userDefineLang.xml:9: <Keywords name="Delimiters">&apos;&quot;`&apos;&quot;`</Keywords> you dropped a zero. is that just ...
10 years, 10 months ago (2013-06-27 16:55:01 UTC) #2
chai2010
Please take another look. https://codereview.appspot.com/10480044/diff/3001/misc/notepadplus/userDefineLang.xml File misc/notepadplus/userDefineLang.xml (right): https://codereview.appspot.com/10480044/diff/3001/misc/notepadplus/userDefineLang.xml#newcode9 misc/notepadplus/userDefineLang.xml:9: <Keywords name="Delimiters">&apos;&quot;`&apos;&quot;`</Keywords> On 2013/06/27 16:55:01, ...
10 years, 10 months ago (2013-06-28 02:40:22 UTC) #3
r
This is a much more sweeping change now. I would like a notepad user to ...
10 years, 10 months ago (2013-07-19 00:16:10 UTC) #4
chai2010
Thanks for the comments on the English. https://codereview.appspot.com/10480044/diff/17001/misc/notepadplus/README File misc/notepadplus/README (right): https://codereview.appspot.com/10480044/diff/17001/misc/notepadplus/README#newcode4 misc/notepadplus/README:4: The userDefineLang.xml ...
10 years, 10 months ago (2013-07-19 01:03:34 UTC) #5
r
LGTM I will update the change description to say: Fixes issue 5775. Fixes issue 5788. ...
10 years, 9 months ago (2013-07-26 22:12:33 UTC) #6
r
10 years, 9 months ago (2013-07-26 22:13:10 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=ac410fc1fe6c ***

misc/notepadplus: use new User Defined Language system (UDL2)

Add missing single quotation and backslash marks.

Change dot and underscore character keyword type.
"_" is a predeclared identifier, not a operator.
"." is a selector, x.f should be one identifier highlight.
So the fix is to change it.

Fixes issue 5775.
Fixes issue 5788.
Fixes issue 5798.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10480044

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b